Skip to content
Snippets Groups Projects

Bug Fix: path in git version script

Closed Mikkel Friis-Møller requested to merge jantoreh:BugFix-GitVersion into master

Created by: jantoreh

Merge request reports

Checking pipeline status.

Closed by avatar (Mar 14, 2025 6:04am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: davidovitch

    This is peculiar, in my Visual Studio 2010 setup the base path is defined as src/dtu_we_controller because src/get_git_version.bat is called in a pre-build step for this project. Since src/get_git_version.bat starts with moving one directory upwards, we end up in the src directory. This works fine on my system with Visual Studio 2010. How are you compiling the project, and why is it different for your setup? (note that I am not exactly a Visual Studio expert).

  • Created by: jantoreh

    I am compiling with Make in both Linux and Windows. It makes sense if the get_git_version.bat file is executed in the src/dtu_we_controller folder. I was testing by executing the .bat file with a double-clck in Windows, which requires the propsed change to work. But if it works in VS, I can manage with the current setup.

  • Created by: davidovitch

    Shouldn't we make sure that the whole setup works for both the makefile and the Visual Studio solution file, and on both Windows and Linux? I welcome any MR to that end, and I don't mind changing the Visual Studio solution file if that means we have a more elegant makefile and/or Linux build procedure.

  • Created by: jantoreh

    Agree. I will let you know if I should find a working solution.

Please register or sign in to reply
Loading