Skip to content

Clean up compilation architecture

sgho requested to merge develop_jess_sgho into master

@dave, I let you handle the cleaning of the compilations from this point.

Things that I anticipate:

  • Update the Visual Studio projects (*snl *vproj), or otherwise just delete them
  • *.vfproj and *.sln files have been removed from the sub-src folder (each sub-src folder contains the source code for compiling different dlls under Windows or *.so under Linux;
  • Should we bring back write_version?
  • No, we will not use the write_version, instead we will use ./utils/version/BuildInfo.f90
  • Review the structure that is used to store the compilation files (right now they are under /src, which is very confusing, and they co-exist with many other types of files).
  • For now, we decide to store CMakeLists.txt files together with the *.f90 files in each sub-src folders
  • Tests that the controllers are working (i.e. flap_controller_cyclic, that is the one I brought back to life)
  • Thanks Sergio for fixing the problem of compiling the flap_controller_cyclic. Now it will be merged to the master;
  • General clean up of the code in terms of comments (especially with regards to the compilation files)
  • Check the docs subfolder and the README to adapt to changes/check that is updated.
  • I will move this to-do's to the Additional to-do's, since there is a separate repository for storing the manuals;
  • Review issues #37 (closed), #35 (closed) and #10 (closed), since this dev may have a direct impact on those problems.
  • issue #37 (closed) (Error in Linux compilation) is solved. I will close issue #37 (closed) after this merge;
  • issue #35 (closed) (compiling for FAST) is solved. I will close issue #35 (closed) after this merge;
  • issue #10 (closed) (Make and gfortran compiling) is solved. I will close issue #10 (closed) after this merge;

Other steps that still need to be taken (will be handled in other issues):

  • Document the flap_controller_cyclic controller (see issue #49)
  • Extend CI with a Linux build (see issue #48)
  • Check in the tests if all binaries are present in the build, return failure if not (see issue #46)
  • Check the docs subfolder and the README to adapt to changes/check that is updated (see issue #47)
Edited by famen

Merge request reports