Skip to content
Snippets Groups Projects

fixing the gradient optimization of IRR

Closed Pierre-Elouan Rethore requested to merge fix_integer_irr into master

SLSQP doesn't work with IRR. That's because in the cashflow method, the AEP is added as an int. This made the finite difference not work properly. Another fix of this branch is adding a dependency to numpy_financial, as the IRR function has moved from numpy to numpy_financial in the most recent versions of numpy.

Edited by Pierre-Elouan Rethore

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @mmpe: I'm having trouble passing the tests, could you please help me out figuring what's going on? Thanks!

    Edited by Pierre-Elouan Rethore
  • Pierre-Elouan Rethore changed title from fixing the gradient optimization with respect to IRR to fixing the gradient optimization of IRR

    changed title from fixing the gradient optimization with respect to IRR to fixing the gradient optimization of IRR

  • It is three different things:

    • The linux test fails because it uses the newest version PyWake which do not have the CubePower function in py_wake.windturbines
    • the pycodestyle test fails because of some indent inconsistencies
    • the windows test fails because a result value has changed. It will probably fail too, when PyWake is updated on the test machine or an update of pywake is added to the ci
Please register or sign in to reply
Loading