Skip to content
Snippets Groups Projects

Only use one HAWC2 io reader

    • Closed Issue created by David Verelst @dave

    There are two different IO readers now:

    • prepost.windIO.LoadResults
    • hawc2.Hawc2io.ReadHawc2

    There should only be one! It should also have a logical name. Repeating HAWC2 3 times is a bit verbose...

    Designs

      Child items ...

      2. Activity

      • Mads M. Pedersen
        Mads M. Pedersen @mmpe ·
        Owner

        is this fixed by carlos !4 (merged)

      • David Verelst
        David Verelst @dave ·
        Author Owner

        Yeah, lets close this. I think there is more room for improvement for cleaning up code in prepost, but lets keep it focussed. I think we should also be careful when naming modules, classes and methods. For instance we have:

        from wetb.hawc2.Hawc2io import ReadHawc2

        That is 3x times hawc2 :-) This kind of re-factoring should not be our current priority though...

      • David Verelst Status changed to closed

        Status changed to closed

      Please register or sign in to reply