Skip to content
Snippets Groups Projects

Updated docs with more Windows info

Closed Jenni Rinker requested to merge (removed):rink into master

Updated text in "howto-make-dlcs.md" to have more info for Windows users (PuTTY, mapping network drives, etc). Details on what text was changed can be found in the commit message of this branch.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @dave

  • Thank you, thank you, thank you. So nice when people contribute. It is Davids work, you are improving, so he will respond to you regarding the merge, but it looks as if you have added three *.c files

    • wetb/fatigue_tools/rainflowcounting/pair_range.c
    • wetb/fatigue_tools/rainflowcounting/peak_trough.c
    • wetb/fatigue_tools/rainflowcounting/rainflowcount_astm.c

    which is not the intension as they are autogenerated during install.

    Edited by Mads M. Pedersen
  • closed

  • Author Maintainer

    It's long overdue -- I should have contributed a long time ago.

    Thanks for the note. In addition to those files, I see that I also have some extraneous commits that I didn't want in this merge request. I'm going to close this request, create a new branch off the master, update the docs, and create a new "clean" request.

    Edited by Jenni Rinker
  • I think it is possible to rebase, and I would like to know how, maybe @dave can help

  • Author Maintainer

    I suspect you're right. But I think I had some bogus commits, then I compiled and generated the .c files, so in the end I would just be resetting to the master branch anyway. I think David is gone for the day, so in the interest of making something easy to merge tomorrow I'll just create the new branch and merge request tonight. But I also want to hear the answer to this issue later.

    David, sorry for the bazillion emails...

  • Awesome!! No worries, I really appreciate that you want to make this package better. I am swamped this week, I will give it look very soon.

Please register or sign in to reply
Loading